chore(deps): migrate to react 17.x#205
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates this React component library to target React 17, removing deprecated DOM-node access and cleaning up related test/dependency tooling.
Changes:
- Bump
react/react-domto^17.0.0(dev + peer deps). - Remove Enzyme + React 16 Enzyme adapter dependencies.
- Replace
ReactDOM.findDOMNode(...)usage with a direct ref (getBoundingClientRect()), and update.gitignore.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Updates React/ReactDOM to 17 and removes Enzyme tooling from dependencies. |
src/components/schedule-builder-view/schedule-event-list.js |
Removes findDOMNode usage in favor of direct DOM ref access (React 17-compatible). |
yarn.lock |
Lockfile updates reflecting React 17 upgrade and removal of Enzyme-related packages. |
.gitignore |
Ignores .codegraph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: smarcet <smarcet@gmail.com>
smarcet
force-pushed
the
feature/5.x-react-17-x-upgrade
branch
from
656c91a to
9c5a9b9
Compare
* feat: add mui componentes from summit-admin * fix: adding tests * fix: change react version to match admin, fix queries * fix: query action * fix: PR review feedback * fix: update pricefield * chore(deps): migrate to react 17.x (#205) * chore(deps): migrate to react 17.x * chore: fix warnings Signed-off-by: smarcet <smarcet@gmail.com> * chore(unit-tests): fix --------- Signed-off-by: smarcet <smarcet@gmail.com> * fix: price field null value --------- Signed-off-by: smarcet <smarcet@gmail.com> Co-authored-by: sebastian marcet <smarcet@gmail.com>
Summary by CodeRabbit